Asyncio Module Compact Serialization [6/6]#752
Merged
Conversation
- Fixed a bug where an asyncio Lock was tried to be acquired without a release - Store asyncio tasks in order not to lose them - Removed start/shutdown from AsyncioReactor
…integration-tests2
…integration-tests2
emreyigit
approved these changes
Dec 3, 2025
emreyigit
left a comment
Member
There was a problem hiding this comment.
Biggest thing in the PR is compact tests. And, it looked same to me compared to existing compact tests.
# Conflicts: # hazelcast/internal/asyncio_connection.py # hazelcast/internal/asyncio_reactor.py
ihsandemir
approved these changes
Dec 4, 2025
* Removed unnecessary client components * Converted partition service to async * Ported compact compatibility test
Contributor
Author
|
@ihsandemir @emreyigit I've added some more code to this PR at: I've removed unused components of the client, ported partition service, and ported compact compatibility tests. Please add review comments if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.